OWNERS: Upstream docs moved from devel/ to guide/#15
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Jul 25, 2018
Merged
OWNERS: Upstream docs moved from devel/ to guide/#15k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
size/XS
wking
force-pushed
the
owners-docs-moved
branch
2 times, most recently
from
76dbc64 to
0e14131
Compare
Contributor
Author
|
/assign @sarahnovotny |
Catch up with kubernetes/community@02a00faf (Move owners file to the contributor guide, 2018-02-08, kubernetes/community#1764). I've also shifted the README link to a reference-style link [1], so we can update the URI in the future without having to touch our surrounding text. And while I'm touching the README line, I've added backticks around OWNERS so we're internally consistent on that line ;). [1]: https://daringfireball.net/projects/markdown/syntax#link
wking
force-pushed
the
owners-docs-moved
branch
from
0e14131 to
e2fb2d3
Compare
So readers don't have to scroll down to find it.
Contributor
Author
|
Anything I can do to help this along? The links currently in master are 404ing. |
Member
|
/unassign sarahnovotny |
k8s-ci-robot
added
the
lgtm
Contributor
Author
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, spiffxp, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 25, 2018
Most of the folks I've listed here are under Aaron in Red Hat, with Yifan being the installer lead. I've also included Alex and Clayton, who are higher up in Red Hat but still members of @openshift/installer. I'm guessing about roles, but we can always adjust later as we see fit. Approvers can also /lgtm [1], so there's no need to list them under 'reviewers' as well. The docs link in OWNERS is from [2]. While updating CONTRIBUTING.md to mention OWNERS (using wording based on [3]), I've also: * Added a line to make it clear that filing issues is helpful to (for folks who don't have the time or inclination to work up a PR). * Turned the unordered list into an ordered list. These entries happen sequentially, and an ordered list makes that more obvious. * Made "below" a link, to make finding the referenced content more convenient. * Shuffled words in the commit message format title to make it shorter. The references to 'make structure-check' are stale since d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), but I've left fixing that to follow-up work. [1]: https://github.com/kubernetes/community/blob/4c0c2e9e659d2f989f3d23c3634c16bb099f3064/contributors/guide/owners.md#quirks-of-the-process [2]: kubernetes/kubernetes-template-project#15 [3]: https://github.com/kubernetes/kubernetes-template-project/blame/16f1588e6d4746876beb08cc64769657530d4872/CONTRIBUTING.md#L10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch up with kubernetes/community#1764.