Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinder: support and test the --experimental-patches flag for kubeadm #2184

Merged
merged 2 commits into from
Jul 6, 2020
Merged

kinder: support and test the --experimental-patches flag for kubeadm #2184

merged 2 commits into from
Jul 6, 2020

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 14, 2020 •
edited
Loading

  • Add test workflows
  • Add the flag "--patches" for "kinder do"
  • Bind the flag to init, join, upgrade.
  • Support only Nodes that are >= 1.19.
  • Use the same directory constant for kustomize / patches "PatchesDir".

xref #2046

/kind feature
/area kinder test
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/kinder Issues to track work in the kinder tool priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 14, 2020
@k8s-ci-robot
Copy link
Contributor

@neolit123: The label(s) area/test cannot be applied, because the repository doesn't have them

In response to this:

  • Add test workflows
  • Add the flag "--patches" for "kinder do"
  • Bind the flag to init, join, upgrade.
  • Support only Nodes that are >= 1.19.
  • Use the same directory constant for kustomize / patches "PatchesDir".

/kind feature
/area kinder test
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 14, 2020
@neolit123 neolit123 changed the title kinder: support and test the --experimental-patches flag for kubeadm WIP: kinder: support and test the --experimental-patches flag for kubeadm Jun 14, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2020
@neolit123 neolit123 added this to the v1.19 milestone Jun 14, 2020
@neolit123 neolit123 mentioned this pull request Jun 14, 2020
Closed
14 tasks
fabriziopandini
fabriziopandini reviewed Jun 16, 2020
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first pass, overall lgtm. Great work!

kinder/ci/workflows/patches-tasks.yaml
EOF

chmod +x /tmp/verify-patches.sh
- name: copy verify-patches.sh on controlplane nodes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As alternative to this approach, it is now possible to add those files at build time.
But I'm fine with both approaches

@neolit123
kinder: add test workflows for the patches functionality
142079f
@neolit123
kinder: support the --experimental-patches flag for kubeadm
a0e92ef 
- Add the flag "--patches" for "kinder do"
- Bind the flag to init, join, upgrade.
- Support only Nodes that are >= 1.19.
- Use the same directory constant for kustomize / patches "PatchesDir".
@neolit123
Copy link
Member Author

/retitle kinder: support and test the --experimental-patches flag for kubeadm

@fabriziopandini this is ready for review. i've removed the WIP.

@k8s-ci-robot k8s-ci-robot changed the title WIP: kinder: support and test the --experimental-patches flag for kubeadm kinder: support and test the --experimental-patches flag for kubeadm Jul 3, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2020
@neolit123
Copy link
Member Author

/retest

@fabriziopandini
Copy link
Member

@neolit123 thanks!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 869d72f into kubernetes:master Jul 6, 2020
This was referenced Jul 6, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@kad kad Awaiting requested review from kad

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @k8s-ci-robot @fabriziopandini