Update structured-merge-diff version #155
Conversation
k8s-ci-robot
added
cncf-cla: yes
jennybuckley
force-pushed
the
update-smd-2
branch
2 times, most recently
from
302c2a9 to
467f441
Compare
go.mod
Outdated
| github.com/google/gofuzz v0.0.0-20161122191042-44d81051d367 | ||
| github.com/googleapis/gnostic v0.0.0-20170426233943-68f4ded48ba9 | ||
| github.com/json-iterator/go v0.0.0-20180612202835-f2b4162afba3 | ||
| github.com/kr/pretty v0.1.0 // indirect |
There was a problem hiding this comment.
running go mod tidy should clean it up. go get will speculatively add things it's unsure about, and go mod tidy will clean them up once it verifies all os/arch/build tag combinations don't need it
There was a problem hiding this comment.
I guess not, it looks like it succeeds the tests when i remove this line
There was a problem hiding this comment.
Not sure how this got here
There was a problem hiding this comment.
When I ran go mod tidy, it didn't remove this, so I just removed it manually.
jennybuckley
force-pushed
the
update-smd-2
branch
from
d3e9750 to
28e4d41
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
5 participants
And make necessary changes to schemaconv to accept the changes
@apelisse
Edit: also needed to run
GO111MODULE=on go mod tidy