Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a temporary staging bucket for kops builds #15981

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Create a temporary staging bucket for kops builds #15981

merged 1 commit into from
Oct 6, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Oct 1, 2023 •
edited
Loading

Right now, kops assets get staged at the kops-ci bucket which is not writable if you migrate the job to the community cluster.

This change creates a public temporary staging bucket if you lease a project from boskos, similar to how we create the state buckets today.

@rjsadow You should be able to migrate kops GCE presubmits after this is merged.

Part of kubernetes/test-infra#29722

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2023
@upodroid upodroid force-pushed the boskos-support branch 3 times, most recently from 249c193 to eed4487 Compare October 1, 2023 15:55
@upodroid
Copy link
Member Author

upodroid commented Oct 1, 2023

This change works as intended, however the google.com projects are enforcing a constraint that blocks public buckets from being created.

I'll move one of the optional GCE presubmits to the community cluster and prep a separate PR to move all of them

@upodroid upodroid mentioned this pull request Oct 1, 2023
Merged
@upodroid
Copy link
Member Author

upodroid commented Oct 1, 2023

/test pull-kops-kubernetes-e2e-cos-gce-serial

@upodroid
Copy link
Member Author

upodroid commented Oct 1, 2023

/test pull-kops-kubernetes-e2e-cos-gce-serial

1 similar comment
@upodroid
Copy link
Member Author

upodroid commented Oct 1, 2023

/test pull-kops-kubernetes-e2e-cos-gce-serial

@upodroid upodroid force-pushed the boskos-support branch 2 times, most recently from 34a602e to 839c0cb Compare October 1, 2023 21:54
@upodroid
Copy link
Member Author

upodroid commented Oct 1, 2023

/test pull-kops-kubernetes-e2e-cos-gce-serial

@upodroid
Copy link
Member Author

upodroid commented Oct 2, 2023

The serial job launched properly (test failures are expected)

@upodroid upodroid mentioned this pull request Oct 2, 2023
Open
@hakman
Copy link
Member

hakman commented Oct 5, 2023

/test pull-kops-kubernetes-e2e-cos-gce-serial

@upodroid upodroid mentioned this pull request Oct 6, 2023
Merged
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

kops on AWS loads kops from gs://kops-ci or gs://k8s-staging-kops. Opening a separate issue to stage kops binaries to a bucket in the AWS account kops will run in.

The IAM failure on the AWS jobs will be fixed once the linked PR in k/k8s.io is merged

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/retest

AWS tests should work now

@upodroid upodroid mentioned this pull request Oct 6, 2023
Merged
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/retest

1 similar comment
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/retest

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

It works

@justinsb
Copy link
Member

justinsb commented Oct 6, 2023

Thanks @upodroid

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added area/api and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 6, 2023
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

oops wrong PR,

@hakman
Copy link
Member

hakman commented Oct 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 6, 2023 •
edited
Loading

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-kubernetes-e2e-cos-gce-serial 839c0cb link true /test pull-kops-kubernetes-e2e-cos-gce-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/retest

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/test pull-kops-e2e-k8s-aws-calico

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-ipalias

pods got nuked earlier

@k8s-ci-robot k8s-ci-robot merged commit 3d30b40 into kubernetes:master Oct 6, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 6, 2023
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
This was referenced Jul 17, 2024
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 17, 2024
@k8s-ci-robot
Merge pull request #16678 from justinsb/automated-cherry-pick-of-#159…
a031776 
…81-upstream-release-1.28

Automated cherry pick of #15981: create a dedicated staging bucket for kops builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@justinsb justinsb

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@upodroid @hakman @justinsb @k8s-ci-robot