Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint warnings #992

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Fix golint warnings #992

merged 1 commit into from
Apr 27, 2018

Conversation

xianlubird
Copy link
Contributor

@xianlubird xianlubird commented Apr 27, 2018 •
edited
Loading

Fix golint warning

golint ./cmd/... ./build/... ./pkg/... .
pkg/loader/compose/utils.go:37:2: comment on exported const ServiceTypeHeadless should be of the form "ServiceTypeHeadless ..."

Pls @cdrage @hangyan help review. Thanks

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2018
@xianlubird
Copy link
Contributor Author

The continuous-integration fail seems irrelevant to this change. @hangyan

@cdrage
Copy link
Member

cdrage commented Apr 27, 2018

LGTM

@cdrage cdrage merged commit c496fa4 into kubernetes:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangyan hangyan hangyan approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xianlubird @cdrage @hangyan @k8s-ci-robot