Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emptvols -> volumes=yes #811

Merged
merged 1 commit into from
Sep 11, 2017
Merged

emptvols -> volumes=yes #811

merged 1 commit into from
Sep 11, 2017

Conversation

ashetty1
Copy link
Contributor

No description provided.

@kompose-bot
Copy link
Collaborator

@ashetty1, thank you for the pull request! We'll request some people to review your PR. @cdrage, please review this.

@kompose-bot kompose-bot requested a review from cdrage September 11, 2017 13:11
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2017
@cdrage
Copy link
Member

cdrage commented Sep 11, 2017

LGTM

@surajnarwade
Copy link
Contributor

LGTM :)

@cdrage cdrage merged commit 2ed0a32 into kubernetes:master Sep 11, 2017
kadel
kadel reviewed Sep 13, 2017
View reviewed changes
script/test_in_openshift/lib.sh
@@ -192,7 +192,7 @@ function convert::kompose_up () {
# Usage: convert::kompose_up <docker_compose_file>
local compose_file=$1
convert::print_msg "Running kompose up ..."
./kompose up --provider=openshift --emptyvols -f $compose_file
./kompose up --provider=openshift --volumes empty -f $compose_file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious.
Isn't correct value emptyDir? It looks like there is no validation for --volumes values.
ping @cdrage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #814

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadel looking into it. You are right. Also, the help text needs to change,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel left review comments

@cdrage cdrage Awaiting requested review from cdrage

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashetty1 @kompose-bot @cdrage @surajnarwade @kadel @k8s-ci-robot