Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker client from environment variables #746

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

rathko
Copy link
Contributor

@rathko rathko commented Aug 4, 2017

Why:

Currently kompose works only with the hard-coded Unix socket endpoint, which makes it difficult to use with macOS and other non-Linux environments.

What:

Detect if the DOCKER_HOST is set and create a docker client from the environment variables DOCKER_HOST, DOCKER_TLS_VERIFY, and DOCKER_CERT_PATH.

@kompose-bot
Copy link
Collaborator

@rathko, thank you for the pull request! We'll ping some people to review your PR. @cdrage and @surajnarwade, please review this.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 4, 2017
@cdrage
Copy link
Member

cdrage commented Aug 4, 2017

Hey @rathko

Thanks for the contribution!

A few things:

  • Gotta sign the CLA (pain in the ass I know)

  • Do you mind re-basing? I just enabled cluster building for Kubernetes hence the reason why SemaphoreCI just failed

  • Tests fail, mind doing a gofmt on the code? Gotta fix some of that indentation.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 4, 2017
@rathko
Copy link
Contributor Author

rathko commented Aug 4, 2017

@cdrage Thanks, it's rebased, gofmted and CLA is signed. Cheers

@cdrage
Copy link
Member

cdrage commented Aug 4, 2017

SemaphoreCI is being funky, but tests pass and code LGTM 👍

@surajnarwade
Copy link
Contributor

@rathko , Thanks for contribution :)
LGTM for code 👍

Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution @rathko !

@cdrage cdrage merged commit c24be36 into kubernetes:master Aug 8, 2017
@dataminelab dataminelab deleted the docker-endpoint branch August 8, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants