-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docker client from environment variables #746
Conversation
@rathko, thank you for the pull request! We'll ping some people to review your PR. @cdrage and @surajnarwade, please review this. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hey @rathko Thanks for the contribution! A few things:
|
…LS_VERIFY, and DOCKER_CERT_PATH
@cdrage Thanks, it's rebased, |
SemaphoreCI is being funky, but tests pass and code LGTM 👍 |
@rathko , Thanks for contribution :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the contribution @rathko !
Why:
Currently
kompose
works only with the hard-coded Unix socket endpoint, which makes it difficult to use with macOS and other non-Linux environments.What:
Detect if the
DOCKER_HOST
is set and create a docker client from the environment variables DOCKER_HOST, DOCKER_TLS_VERIFY, and DOCKER_CERT_PATH.