Adds Kubernetes cluster tests #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
This adds cluster tests for "kompose up" and "kompose down" for Kubernetes. At the moment this checks that they are deployable to a single-node Kubernetes cluster. More proficient tests such as testing if the pods are actually up will be added in the future. You can test this by running: `make test-ci` on your local-machine. Furthermore, we'll eventually have this enabled on Fabric8 / CentOS CI / Semaphore (whatever comes first) so we can have a full end-to-end testing environment.
cdrage
force-pushed
the
add-cluster-tests
branch
from
262bf2f to
21fefae
Compare
|
@surajnarwade @surajssd @ashetty1 @kadel Please review |
|
@cdrage when I run examples/docker-gitlab.yaml, it throws up volume mount related warnings; the pods are not brought up successfully. How about we add --emptyvols for Also, you aren't checking if the pods are actually running post |
|
@ashetty1 That kind of sucks that our current gitlab example doesn't work... I don't like how we have to pass in Yup, we are currently not checking if each pod are actually running post Can you LGTM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds cluster tests for "kompose up" and "kompose down" for
Kubernetes. At the moment this checks that they are deployable to a
single-node Kubernetes cluster.
More proficient tests such as testing if the pods are actually up will
be added in the future.
You can test this by running:
make test-cion your local-machine.Furthermore, we'll eventually have this enabled on Fabric8 / CentOS CI /
Semaphore (whatever comes first) so we can have a full end-to-end
testing environment.