Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mention bot config #700

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Update mention bot config #700

merged 1 commit into from
Jul 11, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Jul 11, 2017

Removes some of the values which are already set to their default values
on mention bot.

@kompose-bot
Copy link
Collaborator

Unable to parse mention-bot custom configuration file due to a syntax error.
Please check the potential root causes below:

  1. Having comments
  2. Invalid JSON type
  3. Having extra "," in the last JSON attribute

Error message:

Error: Parse error on line 2:
... "maxReviewers": 3, // 3 is enough  "nu
-----------------------^
Expecting 'STRING', got 'undefined'

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2017
@cdrage cdrage force-pushed the update-mention-bot-config branch from e419d90 to 22c16af Compare July 11, 2017 16:02
@cdrage
Update mention bot config
040822e 
Removes some of the values which are already set to their default values
on mention bot.
@cdrage cdrage force-pushed the update-mention-bot-config branch from 22c16af to 040822e Compare July 11, 2017 16:02
@cdrage
Copy link
Member Author

cdrage commented Jul 11, 2017

Going to merge this to fix the bot (wasn't correctly finding reviews due to it being labeled by the CLA bot before declared "open")

@cdrage cdrage merged commit 5f06267 into kubernetes:master Jul 11, 2017
cdrage added a commit to cdrage/kompose that referenced this pull request Jul 11, 2017
@cdrage
Merge pull request kubernetes#700 from cdrage/update-mention-bot-config
57940e8 
Update mention bot config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdrage @kompose-bot @k8s-ci-robot