Fixes fixture test for build context #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
surajnarwade
force-pushed
the
fix-build-test
branch
from
b5cde51 to
cd03085
Compare
|
Tests fail? |
surajnarwade
force-pushed
the
fix-build-test
branch
14 times, most recently
from
a14699e to
cd64d2a
Compare
surajssd
reviewed
May 5, 2017
script/test/cmd/fix_detached_head.sh
Outdated
| # Only do something if the HEAD is detached. | ||
| if [ $(git rev-parse --abbrev-ref HEAD) == 'HEAD' ]; then | ||
| # If the current detached HEAD equals the master, then check out the master. | ||
| [[ $(git rev-parse HEAD) == $(git rev-parse master) ]] && git checkout master |
There was a problem hiding this comment.
not tested, but i think changing to master will not test the current PR
cdrage
reviewed
May 5, 2017
| @@ -0,0 +1,14 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
Would be good to leave a little note where this is coming from :) Source.
Also, missing license!
There was a problem hiding this comment.
@cdrage added license and note
surajnarwade
force-pushed
the
fix-build-test
branch
from
cd64d2a to
f186927
Compare
cdrage
reviewed
May 8, 2017
script/test/cmd/fix_detached_head.sh
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| #Reference Link: https://github.com/theochem/horton/blob/master/tools/qa/fix_detached_head.sh |
|
Other than my comment, LGTM. Side note: Can't wait for #89 is fixed so we don't run into these issues in the future 👍 |
surajnarwade
force-pushed
the
fix-build-test
branch
from
f186927 to
af36e61
Compare
|
@cdrage done |
cdrage
reviewed
May 8, 2017
.travis.yml
Outdated
| @@ -17,6 +17,7 @@ matrix: | |||
|
|
|||
| install: | |||
| - true | |||
| - script/test/cmd/fix_detached_head.sh | |||
There was a problem hiding this comment.
Argh. I should of added a comment here.
Can you put:
// This is required because sometimes Travis ends up in a detached HEAD state after git clone
?
Resolves kubernetes#576 This PR includes `output-os-template.json` in `nginx-node-redis` example, which is basically output template contains `%URI%` and `%REF%` variables which will be filled while initializing test cases and new will be stored as `/tmp/output-os.json` This will remove the problem of git uri and ref.
surajnarwade
force-pushed
the
fix-build-test
branch
from
af36e61 to
aacde86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #576
This PR includes
output-os-template.jsoninnginx-node-redisexample,which is basically output template contains
%URI%and%REF%variableswhich will be filled while initializing test cases and new will be stored as
/tmp/output-os.jsonThis will remove the problem of git uri and ref.