Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document describing release process #551

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Update document describing release process #551

merged 1 commit into from
Apr 10, 2017

Conversation

kadel
Copy link
Member

@kadel kadel commented Apr 7, 2017

Updated release process.
@cdrage, does is describe how you do it?
Is there something important that I forgot?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2017
@kadel kadel requested a review from cdrage April 7, 2017 13:00
cdrage
cdrage reviewed Apr 7, 2017
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should put down the processing of running the release.sh script, no?

I can elaborate on this and make this document more extensive (go into a lot of detail in regards to how we do the release and how to replicate it)

RELEASE.md Outdated
1. An OWNER runs `git tag -s $VERSION` and inserts the changelog and pushes the tag with `git push $VERSION`
1. The release issue is closed
1. An announcement email is sent to `[email protected]` with the subject `[ANNOUNCE] kubernetes-template-project $VERSION is released`
1. An PR is proposing a new release with a changelog since the last release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR proposing a new release

Copy link
Member Author

@kadel kadel Apr 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@kadel
Copy link
Member Author

kadel commented Apr 10, 2017

I believe we should put down the processing of running the release.sh script, no?

yes

I can elaborate on this and make this document more extensive (go into a lot of detail in regards to how we do the release and how to replicate it)

That would be great. I just wanted to update it to something that is at least partial true ;-)

If what I wrote isn't complete nonsense we could merge it, it will be better than what was there before, than you can expand/rewrite it later. What do you think?

@cdrage
Copy link
Member

cdrage commented Apr 10, 2017

@kadel
I agree, let's move fast and merge this for now until we go with some more doc updates!

@cdrage cdrage merged commit a233c81 into kubernetes:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kadel @cdrage @k8s-ci-robot