Added support for different namespaces #517

procrypt · 2017-03-27T19:02:56Z

Now we can deploy application in different namespaces using the --namespace=<value> flag with kompose up and kompose down. The --namepace flag will deploy the application in that particular namespace if, exist.

docker-compose file used.

version: "2"
services:
  web:
    image: tuna/docker-counter23:latest
    ports:
      - "5000:5000"
    links:
      - redis
  redis:
    image: redis:latest
    ports:
      - "6379"

Current namespaces in k8s cluster

$ kubectl get namespace 
NAME          STATUS    AGE
default       Active    3m
development   Active    3m
kube-system   Active    3m

Deploy application in namespace=development

$ kompose up --namespace=development
We are going to create Kubernetes Deployments, Services and PersistentVolumeClaims for your Dockerized application. 
If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead. 

INFO[0000] Deploying application in "development" namespace
 
INFO[0000] Successfully created Service: redis          
INFO[0000] Successfully created Service: web            
INFO[0000] Successfully created Deployment: redis       
INFO[0000] Successfully created Deployment: web         

Your application has been deployed to Kubernetes. You can run 'kubectl get deployment,svc,pods,pvc' for details.

Verify application been deployed in the namespace=development correctly

$ kubectl get deployment,svc,pods,pvc --namespace=development
NAME                        DESIRED      CURRENT             UP-TO-DATE   AVAILABLE   AGE
redis                       1            1                   1            0           2m
web                         1            1                   1            0           2m
NAME                        CLUSTER-IP   EXTERNAL-IP         PORT(S)      AGE
redis                       10.0.0.110   <none>              6379/TCP     2m
web                         10.0.0.55    <none>              5000/TCP     2m
NAME                        READY        STATUS              RESTARTS     AGE
mlbparks-3930800586-mblgc   0/1          Terminating         0            4m
redis-741327525-om0xc       0/1          ContainerCreating   0            2m
web-519030457-28arz         0/1          ContainerCreating   0            2m

Delete the application that has been deployed in the namespace=development

$ kompose down --namespace=development
INFO[0000] Deleting application from "development" namespace
 
INFO[0000] Successfully deleted Service: redis          
INFO[0000] Successfully deleted Service: web            
INFO[0003] Successfully deleted Deployment: redis       
INFO[0006] Successfully deleted Deployment: web

Fixes: #473

CC: @kadel @cdrage @containscafeine @surajssd

surajssd · 2017-03-28T07:51:40Z

if this is being done for up and down then this can/should also be done for convert ??

procrypt · 2017-03-28T08:36:46Z

@surajssd How does it make sense to add this to convert? We can deploy the artifacts created by kompose convert in any namespace we want using kubectl for example,

$ kubectl create -f <file> --namespace=development

Please CMIIW.

cdrage · 2017-03-28T11:37:27Z

I agree with @procrypt that this doesn't make sense to add to convert. Convert simply converts the files and outputs it in the same directory. Using kubectl to bring them up.

cdrage · 2017-03-29T20:33:10Z

cmd/down.go

@@ -56,5 +58,6 @@ var downCmd = &cobra.Command{
 func init() {
 	downCmd.Flags().BoolVar(&DownEmptyVols, "emptyvols", false, "Use Empty Volumes. Do not generate PVCs")
 	downCmd.Flags().IntVar(&DownReplicas, "replicas", 1, "Specify the number of repliaces in the generate resource spec")
+	downCmd.Flags().StringVar(&DownNamespace, "namespace", "", " Specify Namespace to deploy your application")


There's a space before Specify

It may be good to add a default value to this as well, using default namespace.

cdrage · 2017-03-29T20:33:33Z

cmd/up.go

@@ -56,5 +58,6 @@ var upCmd = &cobra.Command{
 func init() {
 	upCmd.Flags().BoolVar(&UpEmptyVols, "emptyvols", false, "Use Empty Volumes. Do not generate PVCs")
 	upCmd.Flags().IntVar(&UpReplicas, "replicas", 1, "Specify the number of repliaces in the generate resource spec")
+	upCmd.Flags().StringVar(&UpNamespace, "namespace", "", " Specify Namespace to deploy your application")


space before Specify

cdrage · 2017-03-29T20:37:41Z

pkg/transformer/kubernetes/kubernetes.go

-	client, namespace, err := k.GetKubernetesClient()
+	client, ns, err := k.GetKubernetesClient()
+	namespace := opt.Namespace
+	if len(namespace) == 0 {


In In order to avoid all of this len and checking against 0, have a look at how we check if a default value is changed in convert.go.

For example:

IsDeploymentFlag: cmd.Flags().Lookup("deployment").Changed,

on line 73.

Instead, you can check to see if the --namespace flag has been set via:

IsNamespaceFlag: cmd.Flags().Lookup("namespace").Changed,

and simply check with

if opt.IsNamespaceFlag { ... }

in the resulting code.

@cdrage Thanks for pointing it out. I have updated the PR 😉

cdrage

Other than a small nitpick, this LGTM.

cdrage · 2017-04-03T15:24:20Z

pkg/transformer/kubernetes/kubernetes.go

 	if err != nil {
 		return err
 	}
+	log.Infof("Deploying application in %q namespace\n", namespace)


No \n. Would just create unneeded space in the output.

procrypt · 2017-04-03T19:15:40Z

@cdrage Updated PR

cdrage · 2017-04-03T19:33:13Z

LGTM!

kadel

We have to add this also for OpenShift

kadel · 2017-04-05T16:03:12Z

pkg/transformer/kubernetes/kubernetes.go

+	if opt.IsNamespaceFlag {
+		namespace = opt.Namespace
+	}
+


I would add similar message as in up informing what namespace used.

@kadel I had added it for down earlier but the issue I faced was, if we run kompose down and there is nothing deployed kompose will still show

INFO[0000] Deleting application in "default" namespace

Hey @procrypt
You may need a rebase since Kompose shouldn't be outputting [0000] in the timestamp.

@cdrage Rebased and updated.

procrypt · 2017-04-11T11:47:51Z

Ping @kadel @cdrage

kadel

one space, and up.go is not formatted according to gofmt, otherwise it looks good

kadel · 2017-04-11T12:59:44Z

cmd/up.go

@@ -59,5 +62,6 @@ func init() {
 	upCmd.Flags().BoolVar(&UpEmptyVols, "emptyvols", false, "Use empty volumes. Do not generate PersistentVolumeClaim")
 	upCmd.Flags().IntVar(&UpReplicas, "replicas", 1, "Specify the number of replicas generated")
 	upCmd.Flags().BoolVar(&UpInsecureRepo, "insecure-repository", false, "Use an insecure Docker repository for OpenShift ImageStream")
+        upCmd.Flags().StringVar(&UpNamespace, "namespace", "default", " Specify Namespace to deploy your application")


There is a space before "Specify"

Now we can deploy application in different namespaces using the "--namespace=<value>" flag with kompose up and kompose down. The --namepace flag will deploy the application in that particular "namespace" if exist."

procrypt · 2017-04-12T13:34:57Z

@kadel @cdrage All green now ☺️

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2017

procrypt force-pushed the new_namespace branch from e01b0da to 6cffefe Compare March 27, 2017 19:37

procrypt force-pushed the new_namespace branch from 6cffefe to 364350a Compare March 28, 2017 08:11

cdrage requested changes Mar 29, 2017

View reviewed changes

procrypt force-pushed the new_namespace branch 2 times, most recently from 5c4bc56 to 7d5264a Compare April 3, 2017 09:14

cdrage requested changes Apr 3, 2017

View reviewed changes

procrypt force-pushed the new_namespace branch 2 times, most recently from 847c82d to 5d8489e Compare April 3, 2017 19:14

cdrage approved these changes Apr 3, 2017

View reviewed changes

kadel requested changes Apr 5, 2017

View reviewed changes

kadel reviewed Apr 5, 2017

View reviewed changes

procrypt force-pushed the new_namespace branch 7 times, most recently from 5154e1d to 4764c21 Compare April 10, 2017 07:24

procrypt closed this Apr 11, 2017

procrypt reopened this Apr 11, 2017

procrypt force-pushed the new_namespace branch 3 times, most recently from 2b5f4d0 to 3ae8a58 Compare April 11, 2017 12:17

kadel reviewed Apr 11, 2017

View reviewed changes

procrypt force-pushed the new_namespace branch 4 times, most recently from a5badc0 to 0c1a115 Compare April 12, 2017 13:09

Added support for different namespaces

f41985a

Now we can deploy application in different namespaces using the "--namespace=<value>" flag with kompose up and kompose down. The --namepace flag will deploy the application in that particular "namespace" if exist."

procrypt force-pushed the new_namespace branch from 0c1a115 to f41985a Compare April 12, 2017 13:10

kadel approved these changes Apr 12, 2017

View reviewed changes

kadel merged commit 3dd41ec into kubernetes:master Apr 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for different namespaces #517

Added support for different namespaces #517

procrypt commented Mar 27, 2017

surajssd commented Mar 28, 2017

procrypt commented Mar 28, 2017 •

edited

Loading

cdrage commented Mar 28, 2017

cdrage Mar 29, 2017

cdrage Mar 29, 2017

cdrage Mar 29, 2017

procrypt Apr 3, 2017

cdrage left a comment

cdrage Apr 3, 2017

procrypt commented Apr 3, 2017

cdrage commented Apr 3, 2017

kadel left a comment •

edited

Loading

kadel Apr 5, 2017

procrypt Apr 5, 2017 •

edited

Loading

cdrage Apr 5, 2017

procrypt Apr 10, 2017

procrypt commented Apr 11, 2017

kadel left a comment

kadel Apr 11, 2017

procrypt commented Apr 12, 2017

Added support for different namespaces #517

Added support for different namespaces #517

Conversation

procrypt commented Mar 27, 2017

surajssd commented Mar 28, 2017

procrypt commented Mar 28, 2017 • edited Loading

cdrage commented Mar 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdrage left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

procrypt commented Apr 3, 2017

cdrage commented Apr 3, 2017

kadel left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

procrypt Apr 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

procrypt commented Apr 11, 2017

kadel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

procrypt commented Apr 12, 2017

procrypt commented Mar 28, 2017 •

edited

Loading

kadel left a comment •

edited

Loading

procrypt Apr 5, 2017 •

edited

Loading