Added dockerfile key support #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Wouldn't it have to be removed from: https://github.com/kubernetes-incubator/kompose/blob/master/pkg/loader/compose/compose.go#L80 as well? |
|
Tests need to be added too (cmd tests) |
yes, It shouldn't be there in the first place :-D This only tracks top level service keys, dockerfile is hidden in build key |
surajnarwade
force-pushed
the
add_dockerfile_support
branch
from
0727418 to
bb1b52e
Compare
|
Few spelling errors in the commit message: Please give an example as well in the commit message / elaborate :) |
surajnarwade
force-pushed
the
add_dockerfile_support
branch
from
bb1b52e to
61d4692
Compare
|
needs rebase, but otherwise lgtm |
Fixes kubernetes#486 This commit will add `dockerfilepath` key under Dockerstratergy in buildconfig. dockerfilepath allow us to use dockerfiles which are named different than `Dockerfile` which are placed in context directory. for example, for a docker-compose file: ``` version: "2" services: foo: build: context: "./build" dockerfile: "Dockerfile-alternate" command: "sleep 3600" ``` Resulting buildconfig will be: ``` apiVersion: v1 kind: BuildConfig ... ... strategy: dockerStrategy: dockerfilePath: Dockerfile-alternate type: Docker ... ... ```
surajnarwade
force-pushed
the
add_dockerfile_support
branch
from
61d4692 to
ec897ef
Compare
|
@kadel , done with rebase |
|
@surajnarwade thank you for updating the commit message. LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
This commit will add
dockerfilepathkey under Dockerstratergy in Buildconfig.dockerfilepath allow us to use dockerfiles which are named different than
Dockerfile