Remove extend from unused keys, add to conversion doc #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the "unsupported" extends from the list (since we actually support) as well as add a clarificiation on the conversion.md document. Closes kubernetes#475 Closes kubernetes#493
k8s-ci-robot
added
the
cncf-cla: yes
surajssd
reviewed
Mar 16, 2017
| @@ -18,7 +18,7 @@ This document outlines all the conversion details regarding `docker-compose.yaml | |||
| | env_file | | N | | | | |||
| | environment | | Y | [Pod.Spec.Container.Env](https://kubernetes.io/docs/api-reference/v1/definitions/#_v1_envvar) | | | |||
| | expose | | Y | [Service.Spec.Ports](https://kubernetes.io/docs/api-reference/v1/definitions/#_v1_containerport) | | | |||
| | extends | v2 | N | | | | |||
| | extends | v2 | Y | | Extends by utilizing the same image supplied | | |||
There was a problem hiding this comment.
can we also mention which type of extend is supported? Because only one type is supported right now!
There was a problem hiding this comment.
Technically it is supported, it just doesn't work 🤣
There was a problem hiding this comment.
what he said ^^. This PR all good for a review / merge?
kadel
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "unsupported" extends from the list (since we actually
support) as well as add a clarificiation on the conversion.md document.
Closes #475
Closes #493