Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with multiple go versions #449

Merged
merged 2 commits into from
Feb 24, 2017
Merged

Test with multiple go versions #449

merged 2 commits into from
Feb 24, 2017

Conversation

kadel
Copy link
Member

@kadel kadel commented Feb 24, 2017

go vet in go 1.8 started complaining about tag format.

pkg/kobject/kobject.go:60: struct field tag `compose:"image",bundle:"Image"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces

This fixes tag formatting in KObject and updates travis.yaml so it runs tests on multiple go versions 1.6, 1.7 and 1.8

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2017
@cdrage
Copy link
Member

cdrage commented Feb 24, 2017

LGTM 👍

@cdrage cdrage merged commit 121011e into kubernetes:master Feb 24, 2017
@kadel kadel mentioned this pull request Feb 27, 2017
Closed
@kadel kadel deleted the multiple-go-versions branch February 27, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kadel @cdrage @k8s-ci-robot