Abstract out api.pod spec

[procrypt]

Fixes: #348
cc: @containscafeine @kadel @cdrage @surajssd

[kadel]

PodSpec is also used in OpenShift transformer. It would be great to use podspec function also there.

[cdrage]

should be podSpec (Go name conventions)

[kadel]

and even better might be initPodSpec similar to other init functions ;-)

[procrypt]

@kadel @cdrage I'm really bad in picking up names 😉 changing it to initPodSpec

[procrypt]

@kadel We can't use PodSpec function in OpenShift because PodSpec in OpenShift is different.
PodSpec in Kubernetes

	pod := api.PodSpec{
		Containers: []api.Container{
			{
				Name:  name,
				Image: service.Image,
			},
		},
	}

PodSpec in OpenShift

	pod := api.PodSpec{
		Containers: []api.Container{
			{
				Name:  name,
				Image: " ",
			},
		},
	}

[kadel]

I think that if we are abstracting podSpec in one place it would be also great to have everywhere else.

If you change your initPodSpec function it can be used also in OpenShift.
You don't have to pass whole service kobject.ServiceConfig struct down to initPodSpec.
All you need is name and image. It could look like this:

func (k *Kubernetes) InitPodSpec(name string, image string) api.PodSpec {
... 

[kadel]

remove " and it will be ok ;-)

[procrypt]

@kadel tests are passing locally when I run make test, no idea what is going wrong in Travis.

[kadel]

LGTM

[cdrage]

LGTM