Generic service type handler for kompose #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdrage I would like your view on the test function being modified and moved to new place, with less checks? Jump to https://github.com/kubernetes-incubator/kompose/pull/277/files#diff-8aba3d6a079386eaab47ed176d32d43cR23 |
cdrage
reviewed
Nov 15, 2016
| @@ -207,6 +207,15 @@ func (c *Compose) LoadFile(file string) kobject.KomposeObject { | |||
| } | |||
| } | |||
|
|
|||
| // canonical custom label handler | |||
There was a problem hiding this comment.
mind adding another comment as to what this actually does, other than "custom label handler"? example?
cdrage
requested changes
Nov 15, 2016
| switch strings.ToLower(ServiceType) { | ||
| case "nodeport": | ||
| return string(api.ServiceTypeNodePort) | ||
| case "", "clusterip": |
There was a problem hiding this comment.
this should be first since it has "". (clusterip, nodeport then loadbalancer)
| case "loadbalancer": | ||
| return string(api.ServiceTypeLoadBalancer) | ||
| default: | ||
| logrus.Fatalf("Unknown value '%s', supported values are 'NodePort, ClusterIP and LoadBalancer' ", ServiceType) |
There was a problem hiding this comment.
or, not and. Should be: NodePort, ClusterIP or LoadBalancer
| t.Errorf("Expected %q, got %q", tt.serviceType, result) | ||
| } | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| svc.Spec.Type = api.ServiceType(service.ServiceType) |
Moved label handling code from Transformer to loader, to make it generic to handle creating service types. Added new attribute to ServiceConfig which gets populated in loader. Fixes kubernetes#273
surajssd
force-pushed
the
generic-service-type
branch
from
e12bf09 to
bb9e4fb
Compare
|
@cdrage addressed all your concerns! |
cdrage
approved these changes
Nov 16, 2016
kadel
approved these changes
Nov 21, 2016
|
@kadel thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved label handling code from Transformer to loader, to make it generic to handle creating service types.
Added new attribute to ServiceConfig which gets populated in loader.
Fixes #273