CreatePVC: correct setting of read/only access #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetkuo
reviewed
Oct 28, 2016
| @@ -175,7 +175,7 @@ func CreatePVC(name string, mode string) *api.PersistentVolumeClaim { | |||
| } | |||
|
|
|||
| if mode == "ro" { | |||
| pvc.Spec.AccessModes = []api.PersistentVolumeAccessMode{"ReadWriteOnce"} | |||
| pvc.Spec.AccessModes = []api.PersistentVolumeAccessMode{"ReadOnlyMany"} | |||
There was a problem hiding this comment.
nit: use api.ReadOnlyMany and api.ReadWriteMany instead
There was a problem hiding this comment.
Update: I meant api.ReadWriteOnce (for the else case)
There was a problem hiding this comment.
this should be fixed now
|
Except for the nit this LGTM |
Fixes kubernetes#237 Also update the code to use the constant values for api.ReadWriteOnce and api.ReadOnlyMany.
dustymabe
force-pushed
the
dusty-fix-readonly
branch
from
f23f882 to
6523da8
Compare
|
@janetkuo sorry about the delay. Have been away from the computer mostly since Friday. |
ngtuna
approved these changes
Nov 2, 2016
ngtuna
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237