Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README with SIG-APPS and Champion #201

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Conversation

sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Oct 12, 2016

some clean up for incubation

Incubation of `kompose` into the Kubernetes project will be discussed in the [API Machinery SIG](https://github.com/kubernetes/community)
Incubation of `kompose` into the Kubernetes project is sheppered in the [SIG-APPS](https://github.com/kubernetes/community).

@ericchiang is acting as Champion for incubation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make his name as link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajssd fixed

@sebgoa sebgoa force-pushed the readme branch 2 times, most recently from 3e22564 to 1678ebb Compare October 12, 2016 07:08
@sebgoa
Copy link
Contributor Author

sebgoa commented Oct 12, 2016

@kadel @ngtuna appreciate a review...simple readme edits...

Incubation of `kompose` into the Kubernetes project will be discussed in the [API Machinery SIG](https://github.com/kubernetes/community)
Incubation of `kompose` into the Kubernetes project is shepherd in the [SIG-APPS](https://github.com/kubernetes/community).

[@ericchiang](https://github.com/ericchiang) is acting as Champion for incubation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing period after "incubation". perhaps add link?
(incupation)[https://github.com/kubernetes/community/blob/master/incubator.md]

since i had to google what "Champion" was and got linked to the incubation doc on kubernetes community

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed.

Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ngtuna
Copy link
Contributor

ngtuna commented Oct 12, 2016

I am gonna make it merge-able by adding approved review. @sebgoa has the whole idea on the incubating progress.

@sebgoa sebgoa merged commit 03aabe1 into kubernetes:master Oct 12, 2016
@sebgoa
Copy link
Contributor Author

sebgoa commented Oct 12, 2016

ok merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants