Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate pre-commit hooks #1559

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

AhmedGrati
Copy link
Contributor

Description

This pull request adds the pre-commit hooks, and fixes our files to comply with the checks integrated into the pre-commit-config.yaml.

@AhmedGrati AhmedGrati requested a review from cdrage January 21, 2023 20:48
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sebgoa January 21, 2023 20:48
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2023
@AhmedGrati AhmedGrati requested review from hangyan and removed request for sebgoa and cdrage January 21, 2023 20:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2023
@cdrage
Copy link
Member

cdrage commented Feb 8, 2023

@AhmedGrati I think something may have messed up with the commit? Looks like it's making changes that aren't about the pre-commit hook

@AhmedGrati
Copy link
Contributor Author

AhmedGrati commented Feb 8, 2023

@cdrage Thank you for pointing out this. In fact, I added pre-commit hooks, and apply these pre-commit hooks to the files so that all checks can pass. Please LMK if you see that it's appropriate to push the pre-commit config without changing files.

@AhmedGrati AhmedGrati force-pushed the feat-add-pre-commit-hooks branch from 0d42c06 to 4d1ce96 Compare February 8, 2023 18:56
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cdrage
Copy link
Member

cdrage commented Feb 8, 2023

@cdrage Thank you for pointing out this. In fact, I added pre-commit hooks, and apply these pre-commit hooks to the files so that all checks can pass. Please LMK if you see that it's appropriate to push the pre-commit config without changing files.

Yeah, I think we should merge the other PR in first, then pre-commit files. But just waiting for the person to update his PR to remove the leftover JS files.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 8, 2023
@AhmedGrati
Copy link
Contributor Author

@cdrage I update it, can you review it please?

@cdrage
Copy link
Member

cdrage commented Feb 10, 2023

LGTM!

@cdrage cdrage merged commit 20dfb84 into kubernetes:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants