-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate pre-commit hooks #1559
Conversation
@AhmedGrati I think something may have messed up with the commit? Looks like it's making changes that aren't about the pre-commit hook |
@cdrage Thank you for pointing out this. In fact, I added pre-commit hooks, and apply these pre-commit hooks to the files so that all checks can pass. Please LMK if you see that it's appropriate to push the pre-commit config without changing files. |
0d42c06
to
4d1ce96
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, I think we should merge the other PR in first, then pre-commit files. But just waiting for the person to update his PR to remove the leftover JS files. |
This reverts commit 4d1ce96.
Signed-off-by: AhmedGrati <[email protected]>
Signed-off-by: AhmedGrati <[email protected]>
@cdrage I update it, can you review it please? |
LGTM! |
Description
This pull request adds the pre-commit hooks, and fixes our files to comply with the checks integrated into the
pre-commit-config.yaml
.