Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #1550

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fix CI #1550

merged 1 commit into from
Jan 13, 2023

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Jan 13, 2023

Fix CI

Accidently removed the check-gofmt.sh script.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2023
@Lctrs
Copy link
Contributor

Lctrs commented Jan 13, 2023

I think this whole script could be just replaced by this Makefile target :

.PHONY: gofmt
gofmt:
	gofmt -l ./

@Lctrs
Copy link
Contributor

Lctrs commented Jan 13, 2023

Nevermind, it never exits with a status other than 0.

@cdrage
Fix CI
dc1d435 
Accidently removed the check-gofmt.sh script.
@cdrage
Copy link
Member Author

cdrage commented Jan 13, 2023 •
edited
Loading

Merging PR as I've fixed the issues! I've also removed SemaphoreCI from within the GitHub settings (we haven't used it for yearssss now).

@cdrage cdrage merged commit d4001c9 into kubernetes:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedGrati AhmedGrati Awaiting requested review from AhmedGrati

@ngtuna ngtuna Awaiting requested review from ngtuna

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdrage @k8s-ci-robot @Lctrs