update Libcompose to v0.3.0 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
force-pushed
the
libcompose-v0.3.0
branch
from
fe9c57b to
06770da
Compare
|
@kadel I think you need to rebase on current master before merge! Once done I will check again :) |
kadel
force-pushed
the
libcompose-v0.3.0
branch
from
06770da to
b301719
Compare
|
rebased |
|
LGTM, build and tests passes locally 👍 |
janetkuo
added
the
lgtm
|
LGTM too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95
I've done some testing on top of our test suite, It shouldn't break anything.
But there was a lot of changes in libcompose, so who knows.