Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go vet is failing locally #825

Closed
surajnarwade opened this issue Sep 26, 2017 · 0 comments
Closed

go vet is failing locally #825

surajnarwade opened this issue Sep 26, 2017 · 0 comments
Assignees
Milestone

Comments

@surajnarwade
Copy link
Contributor

surajnarwade commented Sep 26, 2017

$ make test
go get github.com/mattn/goveralls
go get github.com/modocache/gover
go get github.com/Masterminds/glide
go get github.com/sgotti/glide-vc
go get github.com/golang/lint/golint
go get github.com/mitchellh/gox
./script/check-vendor.sh
Checking for nested vendor dirs
OK
Checking if vendor was cleaned using glide-vc.
OK
./script/check-gofmt.sh
gofmt OK
go vet ./pkg/... ./cmd/... .
pkg/loader/compose/compose_test.go:59: arg expected for printf verb %s of wrong type: github.com/kubernetes/kompose/pkg/kobject.HealthCheck
exit status 1
Makefile:75: recipe for target 'vet' failed
make: *** [vet] Error 1
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Sep 26, 2017
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Sep 26, 2017
`go vet` test was failing while `make test`, This PR will fix this kubernetes#825
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Sep 26, 2017
Fixes kubernetes#825 (since `go vet` was failing locally while doing `make test`)
@surajnarwade surajnarwade self-assigned this Sep 27, 2017
@surajnarwade surajnarwade added this to the 1.3.0 release milestone Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant