docker-compose service with no ports is mapped to k8s svc with no ports

[surajssd]

When a docker-compose service is given with no ports, a corresponding k8s service is created with no port info, and this is wrong config, because port is required value.

docker-compose.yml file I used.

$ cat docker-compose-no-ports.yml 
  mariadb:
    image: centos/mariadb
    environment:
      MYSQL_ROOT_PASSWORD: etherpad
      MYSQL_DATABASE: etherpad
      MYSQL_PASSWORD: etherpad
      MYSQL_USER: etherpad

convert

$ ./kompose convert -f docker-compose-no-ports.yml -o output -y
file "output" created
$ cat output 
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: null
  labels:
    service: mariadb
  name: mariadb
spec:
  ports: []
  selector:
    service: mariadb
status:
  loadBalancer: {}

---
[SNIP]

When this definition is fed to kubernetes it says:

$ kubectl create -f svc 
The Service "mariadb" is invalid.
spec.ports: Required value

Where svc is:

$ cat svc 
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: null
  labels:
    service: mariadb
  name: mariadb
spec:
  ports: []
  selector:
    service: mariadb
status:
  loadBalancer: {}

IMO this should error out or should not create service, give warning loud and clear that service is not created, but still we can have deployment or ReplicationController depending on the provider(k8s/openshift).

[ngtuna]

@surajssd Good catch. Thanks for that. I will add a validation.

[sebgoa]

@ngtuna maybe @surajssd wants to assign this one to himself :)

[kadel]

In Henge we have solved this by interactively asking user to provide missing information.
But I don't think that interactive mode is good fit for Kompose.

[ngtuna]

Somehow, sometimes we might need interactive mode... but I am not sure at this moment we need it..

[ngtuna]

@surajssd can you take this one ?

[surajssd]

@ngtuna sorry for late comment I will take this one!