Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPUSet is read and but do not map to k8s #272

Closed
surajssd opened this issue Nov 7, 2016 · 3 comments
Closed

CPUSet is read and but do not map to k8s #272

surajssd opened this issue Nov 7, 2016 · 3 comments
Assignees

Comments

@surajssd
Copy link
Member

surajssd commented Nov 7, 2016

We do read the CPUSet from docker-compose file and do not map it to any kubernetes constructs. So either add support for it or add it to unsupported keys.

@cdrage
Copy link
Member

cdrage commented Dec 22, 2016

Hmm. Seems that a limit range must be added in order to add this to Kubernetes!

http://kubernetes.io/docs/admin/limitrange/

I'm assuming we should warn the user if CPUSet is set?

@surajnarwade
Copy link
Contributor

@surajssd @cdrage as CPUset is mapped to any k8s key, shall we add it to unsupported keys.

@surajssd
Copy link
Member Author

surajssd commented Apr 4, 2017

@surajnarwade yes SGTM, go ahead with it!

surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 5, 2017
Resolves kubernetes#272 and kubernetes#267

As there is no direct mapping of `cpushares` and `cpuset` to kubernetes,
it should not be read and should be moved to unsupported keys.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 5, 2017
Resolves kubernetes#272 and kubernetes#267

As there is no direct mapping of `cpushares` and `cpuset` to kubernetes,
it should not be read and should be moved to unsupported keys.
qujinping pushed a commit to qujinping/kompose that referenced this issue Apr 25, 2017
Resolves kubernetes#272 and kubernetes#267

As there is no direct mapping of `cpushares` and `cpuset` to kubernetes,
it should not be read and should be moved to unsupported keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants