-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Routes for Services #140
Comments
@kadel sounds good. Only issue will be how to handle this for multiple providers. i.e for vanilla Kubernetes what will the behavior of this expose-service option ? If we implement a --provider we could start adding provider specific options... |
k8s version of Route would be Ingress object |
I still like the idea of using labels to express some of this behavior rather than adding a ton of CLI options. |
This could be solved in similar way as #154 We decided that we are going to use labels to provide additional information for conversion. label for this could look something like this For Kubernetes same thing should be done, but it will create Ingress object instead of Route. |
sounds good, and would resolve this issue for me. |
I believe @containscafeine has volunteered to work on this in the next few weeks. can you assign him on this ? |
@containscafeine any progress on this? |
@dustymabe I've been trying to implement the route API from |
@containscafeine @surajssd If you hit any bumps just ping me I'm happy to help. |
Implements a kompose specific docker compose label "kompose.service.expose" which can be used to expose the specified services externally. The accepted values are of type string. If the value is set to "true", the provider sets the endpoint automatically, and for any other value, the value is set as the hostname. If multiple ports are defined in a service, the first one is chosen to be the exposed. Unit tests, functional tests, glide updates and docs have also been added in this commit for the related feature.
OpenShift can expose Services using Routes.
It would be nice if Kompose created default Routes for some services.
User can specify for which services Route should be created for example like this:
cc: @kbsingh
The text was updated successfully, but these errors were encountered: