Revert "Merge pull request #20 from munnerz/logr"#97
Revert "Merge pull request #20 from munnerz/logr"#97k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
Welcome @liggitt! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks; I strongly agree that klog should do versions properly. |
This reverts commit cd60aa4, reversing
changes made to a6a74fb.
What this PR does / why we need it:
Reverts API-breaking changes in advance of klog/v2
After merging this, the plan is to tag v1.0.0 and switch the module declaration to k8.io/klog/v2 before making breaking changes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):xref https://github.com/kubernetes/client-go/issues/677 Azure/phippyandfriends#30 DataDog/dd-trace-go#482 https://github.com/kubernetes/client-go/issues/658 https://github.com/kubernetes/client-go/issues/656 https://github.com/kubernetes/client-go/issues/654 https://github.com/kubernetes/client-go/issues/652
See discussion in #20 (comment)
/cc @dims @munnerz @deads2k @DirectXMan12