Starting v2 release following API break#91
Conversation
|
/hold (for discussion) |
|
/assign @DirectXMan12 |
|
/assign @liggitt |
|
if we're committed to cd60aa4 (which still seems strange to me, see comment at #20 (comment)), then we should definitely rev the version to avoid breaking consumers. in addition to this, I think we'd want to do something like create a |
|
I replied a bit to your comment in #20 (comment) and #20 (comment). TL;DR: this is a decent stopgap till we can get through a KEP to switch all of client-go and friends over to structured logging natively. That's a lot more work longterm, though (I'd like to get it done, but even if we were to start now, it'd still be a while). |
|
+1 to get this in AND cut a release-1.x branch AND v1.0.0 tag at the commit just prior to #20 |
|
we may want to do the /v2 branch approach as well, since a) it gives us a path to do bugfixes on v1 and b) considering the number of people trying to |
|
/hold cancel |
|
do you need to change |
|
and update the readme to note the minimum go version |
|
might need something like this in travis (dropping go 1.9): |
7bd3f55 to
57f7ec6
Compare
| - 1.9.x | ||
| - 1.10.x | ||
| - 1.11.x | ||
| - 1.12.x |
|
In cd60aa4, we changed the API leading to issues like: ``` src/k8s.io/client-go/transport/round_trippers.go:70:11: cannot convert klog.V(9) (type klog.Verbose) to type bool ``` So we should move to v2 of klog Change-Id: Ibf270e0e6dd326fa91d18140e92139455cbe4de0
57f7ec6 to
2bed4d0
Compare
|
fixing test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In cd60aa4, we changed the API leading
to issues like:
So we should move to v2 of klog
Change-Id: Ibf270e0e6dd326fa91d18140e92139455cbe4de0
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: