ktesting: support multi-line result from AnyToStringHook#433
ktesting: support multi-line result from AnyToStringHook#433k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
When the hook returns a multi-line string, for example a YAML dump,
then continuing directly after the end of that string with the next key/value
pair was a bit hard to read:
dra_manager.go:288: I0129 17:41:55.722711] scheduler: Finished GatherAllocatedState allocatedDevices=<struct { Count int "json:\"count\""; Devices []string "json:\"devices\"" }>:
...
- testdra-all-usesallresources-qzvpg.driver/worker-7/worker-7-device-005 err=<nil>: nil
In this example, allocatedDevices was passed by the hook to gomega.Format which
added the type description and then produced YAML. With this change, such
output becomes:
dra_manager.go:288: I0129 17:41:55.722711] scheduler: Finished GatherAllocatedState allocatedDevices=<
<struct { Count int "json:\"count\""; Devices []string "json:\"devices\"" }>:
...
- testdra-all-usesallresources-qzvpg.driver/worker-7/worker-7-device-005
> err=<nil>: nil
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If klog contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
What this PR does / why we need it:
When the hook returns a multi-line string, for example a YAML dump, then continuing directly after the end of that string with the next key/value pair was a bit hard to read:
In this example, allocatedDevices was passed by the hook to gomega.Format which added the type description and then produced YAML. With this change, such output becomes:
Which issue(s) this PR fixes:
kubernetes/kubernetes#136268 (comment)
Special notes for your reviewer:
Release note:
/assign @tallclair