Skip to content

Fix: Ensure constant format strings in fmt and printf calls#417

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
mikelolasagasti:go-1.24-printf
Jan 21, 2025
Merged

Fix: Ensure constant format strings in fmt and printf calls#417
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
mikelolasagasti:go-1.24-printf

Conversation

@mikelolasagasti
Copy link
Copy Markdown

@mikelolasagasti mikelolasagasti commented Jan 20, 2025

Go 1.24 introduces stricter checks for format string validation. This commit fixes an instance where a non-constant format strings is used in calls to functions fmt.Printf.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 20, 2025

This issue is currently awaiting triage.

If klog contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 20, 2025

Welcome @mikelolasagasti!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2025
pohly
pohly reviewed Jan 21, 2025
View reviewed changes
Comment thread integration_tests/internal/main.go Outdated
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2025
@mikelolasagasti
Replace non-constant format string with fmt.Fprintln
3f71f22 
Go 1.24 introduces stricter checks for format string validation. This
commit replaces a non-constant format string in a call to `fmt.Printf`
with `fmt.Fprintln`, ensuring compliance with the new checks.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
pohly
pohly approved these changes Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikelolasagasti, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit e7125f7 into kubernetes:main Jan 21, 2025
@mikelolasagasti mikelolasagasti deleted the go-1.24-printf branch January 21, 2025 09:30
This was referenced Apr 23, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshanarayana harshanarayana Awaiting requested review from harshanarayana

1 more reviewer

@pohly pohly pohly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pohly pohly

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikelolasagasti @k8s-ci-robot @pohly