Skip to content

Add dependabot #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Sep 2, 2024
+12 −0
Merged

Add dependabot #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
version: 2
updates:
- package-ecosystem: gomod
directories:
- "**/*"
schedule:
interval: daily
Copy link
Copy Markdown
Member

@mengjiao-liu mengjiao-liu Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interval: daily
interval: "weekly"

Does the scheduling interval need to be set to daily? Is it too frequent? I think a weekly run is enough.

Copy link
Copy Markdown
Author

@lucacome lucacome Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes much of a difference, with weekly it's more likely that you'll get a bunch of PRs all at once and reach the limit of open PRs

Copy link
Copy Markdown

@pohly pohly Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "limit of open PRs"?

klog does not have external Go dependencies. I am unsure what kind of PRs dependabot will create here and how useful they will be. I suppose we can try it out...

/lgtm
/assign @dims

For approval.

Copy link
Copy Markdown
Author

@lucacome lucacome Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pohly https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit

by default dependabot only opens 5 PRs for every package-ecosystem at a time


- package-ecosystem: github-actions
directory: /
schedule:
interval: daily