-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: Backfill most recent debian-base, debian-iptables, and pause #835
Conversation
'pull-kubernetes-cross' expects debian-base and debian-iptables to be in the same registry. As we haven't promoted a new debian-iptables image yet, we need to backfill the most recent version into community infra. We do the same for the debian-base and pause images to support anyone who wants to move to the new image registry without changing image versions as well. Versions backfilled: - debian-base (all arches): v2.0.0 - debian-iptables (all arches): v12.0.1 - pause (all arches): 3.2 Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
'pull-kubernetes-cross' expects base images in the form: 'image-<arch>:version', which means we need to push all image names, despite the fat manifest. We can refactor the release libs at a later date, but for now, this should unblock build/promotion of debian-iptables. Signed-off-by: Stephen Augustus <[email protected]>
/hold cancel Here's a janky script to backfill images: #!/usr/bin/env bash
arches=(
"null"
"amd64"
"arm"
"arm64"
"ppc64le"
"s390x"
)
image_name="$1"
version="$2"
project="$3"
for arch in "${arches[@]}"; do
if [[ "$arch" == "null" ]]; then
image="$image_name:$version"
else
image="$image_name-$arch:$version"
fi
docker pull "k8s.gcr.io/$image"
docker tag "k8s.gcr.io/$image" "gcr.io/k8s-staging-$project/$image"
docker push "gcr.io/k8s-staging-$project/$image"
done And the backfill:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justaugustus Your backfill script should use |
Backfill most recent
debian-base
,debian-iptables
, andpause
pull-kubernetes-cross
expectsdebian-base
anddebian-iptables
to be inthe same registry. As we haven't promoted a new
debian-iptables
imageyet, we need to backfill the most recent version into community infra.
We do the same for the
debian-base
and pause images to support anyonewho wants to move to the new image registry without changing image
versions as well.
Versions backfilled:
debian-base
(all arches): v2.0.0debian-iptables
(all arches): v12.0.1pause
(all arches): 3.2Promote all arches for
debian-base-**:v2.1.0
pull-kubernetes-cross
expects base images in the form:image-<arch>:version
, which means we need to push all image names,despite the fat manifest.
We can refactor the release libs at a later date, but for now, this
should unblock build/promotion of
debian-iptables
.Signed-off-by: Stephen Augustus [email protected]
/hold until I actually backfill the images to staging
/assign @dims @cblecker @BenTheElder @listx
cc: @kubernetes/release-engineering
/sig release
/area release-eng dependency security