add promoter for kube-scheduler-simulator#5178
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Apr 28, 2023
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/registry.k8s.io
sanposhiho
force-pushed
the
promoter-scheduler-simulator
branch
from
b53ee40 to
821244a
Compare
Member
|
There are also a few things missing like the |
Member
Author
|
We already have images.yaml. But do we need any other stuff? |
Member
Oh. Sorry I confused the path. Should be good. /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to have promoter-manifest.yaml so that the images are promoted.