Add capi-openstack repo#351
Conversation
|
Welcome @sbueringer! |
|
Hi @sbueringer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
detiber
left a comment
There was a problem hiding this comment.
The general configuration lgtm, but as you mentioned in chat the string length will be an issue. +1 on rename to capi-openstack and we'll follow suit with other cluster-api-aws later as well.
infra/gcp/ensure-staging-storage.sh
Outdated
| cip-test | ||
| cluster-api | ||
| cluster-api-aws | ||
| cluster-api-openstack |
There was a problem hiding this comment.
Follow up from separate conversation, I think capi-openstack is probably better here, and we can look at porting over renaming cluster-api-aws to capi-aws as part of v1alpha3 work.
There was a problem hiding this comment.
I shortened the name as discussed
|
/assign @dims |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
2019/09/04 15:15:12 ======================= Updates ========================= |
Thx! |
|
thanks! |
No description provided.