Skip to content

Add capi-openstack repo#351

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
sbueringer:capo-repo-setup
Sep 4, 2019
Merged

Add capi-openstack repo#351
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
sbueringer:capo-repo-setup

Conversation

@sbueringer
Copy link
Member

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @sbueringer!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sbueringer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/k8s-infra labels Sep 3, 2019
Copy link
Contributor

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general configuration lgtm, but as you mentioned in chat the string length will be an issue. +1 on rename to capi-openstack and we'll follow suit with other cluster-api-aws later as well.

cip-test
cluster-api
cluster-api-aws
cluster-api-openstack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up from separate conversation, I think capi-openstack is probably better here, and we can look at porting over renaming cluster-api-aws to capi-aws as part of v1alpha3 work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shortened the name as discussed

@sbueringer sbueringer changed the title [WIP] Add cluster-api-openstack repo Add capi-openstack repo Sep 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2019
@sbueringer
Copy link
Member Author

/assign @dims

@detiber
Copy link
Contributor

detiber commented Sep 4, 2019

/lgtm
/ok-to-test
/assign @dims

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2019
@dims
Copy link
Member

dims commented Sep 4, 2019

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 56dd8c9 into kubernetes:master Sep 4, 2019
@dims
Copy link
Member

dims commented Sep 4, 2019

2019/09/04 15:15:12 ======================= Updates =========================
2019/09/04 15:15:23 Trying to create group: k8s-infra-staging-capi-openstack@kubernetes.io
2019/09/04 15:15:23 > Successfully created group k8s-infra-staging-capi-openstack@kubernetes.io
2019/09/04 15:15:24 > Successfully updated group settings for k8s-infra-staging-capi-openstack@kubernetes.io to allow external members and other security settings
2019/09/04 15:15:25 Added sbueringer@gmail.com to k8s-infra-staging-capi-openstack@kubernetes.io as a MEMBER
2019/09/04 15:15:26 Added jichenjc@cn.ibm.com to k8s-infra-staging-capi-openstack@kubernetes.io as a MEMBER

@sbueringer sbueringer deleted the capo-repo-setup branch September 4, 2019 19:22
@sbueringer
Copy link
Member Author

2019/09/04 15:15:12 ======================= Updates =========================
2019/09/04 15:15:23 Trying to create group: k8s-infra-staging-capi-openstack@kubernetes.io
2019/09/04 15:15:23 > Successfully created group k8s-infra-staging-capi-openstack@kubernetes.io
2019/09/04 15:15:24 > Successfully updated group settings for k8s-infra-staging-capi-openstack@kubernetes.io to allow external members and other security settings
2019/09/04 15:15:25 Added sbueringer@gmail.com to k8s-infra-staging-capi-openstack@kubernetes.io as a MEMBER
2019/09/04 15:15:26 Added jichenjc@cn.ibm.com to k8s-infra-staging-capi-openstack@kubernetes.io as a MEMBER

Thx!

@jichenjc
Copy link
Contributor

jichenjc commented Sep 5, 2019

thanks!

@dims dims mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants