Skip to content

groups/sig-testing: add k8s-infra-cherrypick-robot#2690

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
spiffxp:k8s-infra-cherrypick-robot
Sep 9, 2021
Merged

groups/sig-testing: add k8s-infra-cherrypick-robot#2690
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
spiffxp:k8s-infra-cherrypick-robot

Conversation

@spiffxp
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp commented Sep 9, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Sep 9, 2021
@spiffxp spiffxp force-pushed the k8s-infra-cherrypick-robot branch from cb5ca22 to 1ad1880 Compare September 9, 2021 19:21
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Sep 9, 2021

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam September 9, 2021 19:24
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Sep 9, 2021

/cc @alvaroaleman

@alvaroaleman
Copy link
Copy Markdown
Member

🎉 yay!
/lgtm
/hold

Feel free to cancel the hold if you want it to merge :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021
- spiffxp@gmail.com
- spiffxp@google.com

- email-id: k8s-infra-cherrypick-robot@kubernetes.io
Copy link
Copy Markdown
Member

@ameukam ameukam Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffxp Will be great to see the password for this account in an 1password vault.

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 9, 2021

/lgtm

@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Sep 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9c94ff6 into kubernetes:main Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
@spiffxp spiffxp deleted the k8s-infra-cherrypick-robot branch September 9, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants