Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/k8s-io: fix go.k8s.io/triage test #2547

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 16, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and nikhita August 16, 2021 16:10
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. wg/k8s-infra labels Aug 16, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2021

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam August 16, 2021 16:10
@rikatz
Copy link
Contributor

rikatz commented Aug 16, 2021

/lgtm
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7ae8d1c into kubernetes:main Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 16, 2021
@spiffxp spiffxp deleted the k8s-triage-redirect-test branch August 27, 2021 11:47
@pacoxu
Copy link
Member

pacoxu commented Sep 14, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-deploy-app-k8s-io/1427287365755342848

FAIL: test_go (__main__.RedirTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test.py", line 198, in test_go
    'https://storage.googleapis.com/k8s-gubernator/triage/index.html')
  File "./test.py", line 100, in assert_temp_redirect
    self.assert_multischeme_redirect(partial_url, expected_loc, 302, **kwargs)
  File "./test.py", line 97, in assert_multischeme_redirect
    scheme + '://' + partial_url, expected_loc, expected_code, **kwargs)
  File "./test.py", line 92, in assert_scheme_redirect
    % (url, expected_loc, resp.getheader('location')))
AssertionError: 'https://storage.googleapis.com/k8s-triage/index.html' != 'https://storage.googleapis.com/k8s-gubernator/triage/index.html'
- https://storage.googleapis.com/k8s-triage/index.html
+ https://storage.googleapis.com/k8s-gubernator/triage/index.html
?                                    +++++++++++
 : 
GET "http://go.kubernetes.io/triage" got an unexpected redirect location:
 want: https://storage.googleapis.com/k8s-gubernator/triage/index.html
 got:  https://storage.googleapis.com/k8s-triage/index.html

The CI failed is related with this ?

@pacoxu
Copy link
Member

pacoxu commented Sep 14, 2021

According to the test failure, we need to revert this PR.

@spiffxp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants