Skip to content

infra/gcp/k8s-infra-public-pii: logs delivery to k8s-infra-artifacts-gcs-logs#2253

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ameukam:fix-binding-cloud-access
Jun 29, 2021
Merged

infra/gcp/k8s-infra-public-pii: logs delivery to k8s-infra-artifacts-gcs-logs#2253
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ameukam:fix-binding-cloud-access

Conversation

@ameukam
Copy link
Copy Markdown
Member

@ameukam ameukam commented Jun 21, 2021

Followup of #2212.

Fix bindings to grant cloud-storage-analytics@google.com permission to
create and store logs in the bucket

Signed-off-by: Arnaud Meukam ameukam@gmail.com

k8s-infra-artifacts-gcs-logs

Followup of kubernetes#2212.

Fix bindings to grant `cloud-storage-analytics@google.com` permission to
create and store logs in the bucket

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ wg/k8s-infra labels Jun 21, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp June 21, 2021 19:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2021
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9becafd into kubernetes:main Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 29, 2021
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jun 29, 2021

Deployed via terraform apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants