prow: add k8s-infra-gci-robot-github-token ExternalSecret#2224
Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom Jun 16, 2021
Merged
prow: add k8s-infra-gci-robot-github-token ExternalSecret#2224k8s-ci-robot merged 2 commits intokubernetes:mainfrom
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
wg/k8s-infra
size/S
Contributor
Author
|
/cc @ameukam |
This was referenced Jun 15, 2021
Contributor
Author
|
#2226 has been deployed (if not yet merged) and I trialed deployment of this to ensure it worked. So this is now ready for merge |
spiffxp
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
|
/approve /hold please feel free to remove hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of umbrella issue to setup a k8s-infra-prow instance on aaa, ref: #1394
Part of umbrella issue to migrate everything to ExternalSecrets, ref: #2220
Depends on #2226 to upgrade aaa's kubernetes-external-secrets to v8.x so we can use the v1 API.