Skip to content

prow: update kubernetes-external-secrets to v8.1.2#2194

Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
spiffxp:upgrade-prow-k-e-s
Jun 11, 2021
Merged

prow: update kubernetes-external-secrets to v8.1.2#2194
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
spiffxp:upgrade-prow-k-e-s

Conversation

@spiffxp
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp commented Jun 10, 2021

Trialing on prow before aaa to verify it comes up OK, and that prow is capable of auto-deploying this

Also using this as an opportunity to exercise the changes in kubernetes/test-infra#22525 and #2190

spiffxp added 2 commits June 10, 2021 18:04
trialing on prow before aaa to verify it comes up ok, and that prow is
capable of auto-deploying this
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 10, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 10, 2021

/cc @ameukam
ref: #2148 (comment)

@k8s-ci-robot k8s-ci-robot requested a review from ameukam June 10, 2021 22:08
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Jun 10, 2021

/lgtm
/hold
Remove hold when ready to deploy.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 11, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit e108c45 into kubernetes:main Jun 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 11, 2021
@spiffxp spiffxp deleted the upgrade-prow-k-e-s branch June 11, 2021 04:39
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 11, 2021

So this failed to deploy automatically, specifically in trying to revoke some existing RBAC permissions:

Error from server (Forbidden): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"rbac.authorization.k8s.io/v1\",\"kind\":\"ClusterRole\",\"metadata\":{\"annotations\":{},\"labels\":{\"app\":\"kubernetes-external-secrets\"},\"name\":\"kubernetes-external-secrets\"},\"rules\":[{\"apiGroups\":[\"\"],\"resources\":[\"secrets\"],\"verbs\":[\"create\",\"update\"]},{\"apiGroups\":[\"\"],\"resources\":[\"namespaces\"],\"verbs\":[\"get\",\"watch\",\"list\"]},{\"apiGroups\":[\"apiextensions.k8s.io\"],\"resourceNames\":[\"externalsecrets.kubernetes-client.io\"],\"resources\":[\"customresourcedefinitions\"],\"verbs\":[\"get\",\"update\"]},{\"apiGroups\":[\"kubernetes-client.io\"],\"resources\":[\"externalsecrets\"],\"verbs\":[\"get\",\"watch\",\"list\"]},{\"apiGroups\":[\"kubernetes-client.io\"],\"resources\":[\"externalsecrets/status\"],\"verbs\":[\"get\",\"update\"]}]}\n"}},"rules":[{"apiGroups":[""],"resources":["secrets"],"verbs":["create","update"]},{"apiGroups":[""],"resources":["namespaces"],"verbs":["get","watch","list"]},{"apiGroups":["apiextensions.k8s.io"],"resourceNames":["externalsecrets.kubernetes-client.io"],"resources":["customresourcedefinitions"],"verbs":["get","update"]},{"apiGroups":["kubernetes-client.io"],"resources":["externalsecrets"],"verbs":["get","watch","list"]},{"apiGroups":["kubernetes-client.io"],"resources":["externalsecrets/status"],"verbs":["get","update"]}]}
to:
Resource: "rbac.authorization.k8s.io/v1, Resource=clusterroles", GroupVersionKind: "rbac.authorization.k8s.io/v1, Kind=ClusterRole"
Name: "kubernetes-external-secrets", Namespace: ""
for: "/home/prow/go/src/github.com/kubernetes/k8s.io/infra/gcp/clusters/projects/k8s-infra-prow-build-trusted/prow-build-trusted/resources/kubernetes-external-secrets_rbac.yaml": clusterroles.rbac.authorization.k8s.io "kubernetes-external-secrets" is forbidden: user "prow-deployer@k8s-infra-prow-build-trusted.iam.gserviceaccount.com" (groups=["system:authenticated"]) is attempting to grant RBAC permissions not currently held:
{APIGroups:[""], Resources:["namespaces"], Verbs:["get" "watch" "list"]}
{APIGroups:[""], Resources:["secrets"], Verbs:["create" "update"]}
{APIGroups:["apiextensions.k8s.io"], Resources:["customresourcedefinitions"], ResourceNames:["externalsecrets.kubernetes-client.io"], Verbs:["get" "update"]}
{APIGroups:["kubernetes-client.io"], Resources:["externalsecrets"], Verbs:["get" "watch" "list"]}
{APIGroups:["kubernetes-client.io"], Resources:["externalsecrets/status"], Verbs:["get" "update"]}

Everything else updated though, so I suspect this is working anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants