Skip to content

prow: make deploy.sh scripts executable#2189

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
spiffxp:chmod-prow-deploy-scripts
Jun 10, 2021
Merged

prow: make deploy.sh scripts executable#2189
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
spiffxp:chmod-prow-deploy-scripts

Conversation

@spiffxp
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp commented Jun 10, 2021

Missed this as part of #2153

@spiffxp
prow: make deploy.sh scripts executable
9d0808a 
add log message to make it clear the script is being executed vs. the
embedded bash in the current postsubmit job configs
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 10, 2021

/cc @BenTheElder @ameukam
(d'oh) the postsubmits are still working via the embedded bash, but I'd like to PR that out next

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 10, 2021

/lgtm
/approve
we have a linter or something for this somewhere

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 10, 2021

I haven't setup shellcheck to run against this repo, maybe that would have caught it?

@k8s-ci-robot k8s-ci-robot merged commit 45a9aef into kubernetes:main Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 10, 2021
@spiffxp spiffxp deleted the chmod-prow-deploy-scripts branch June 10, 2021 21:17
@spiffxp spiffxp mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chases2 chases2 Awaiting requested review from chases2

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@ameukam ameukam Awaiting requested review from ameukam

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@BenTheElder BenTheElder

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

3 participants

@spiffxp @BenTheElder @k8s-ci-robot