audit: add check-audit-pr.sh#2120
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Jun 4, 2021
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/audit
k8s-ci-robot
added
wg/k8s-infra
approved
ameukam
reviewed
Jun 2, 2021
A bunch of bash to try and categorize or triage audit pr changes against policies, triage known policy violations, or special cases. Takes a pass through any modified or untracked files according to git, and commits any that are recognized. The goal is to have 0 files left by the end - check_buckets: - storage class is standard - location type is multi-region - location constraint buckets have location in name - lifecycle is one of well-known cases - logging is one of well-known cases - retention is one of well-known cases (or triage) - triage: ACLs are present - check_compute: - placeholder - check_container: - cluster is one of clusters defined by infra/gcp/clusters - check_iam_in_projects: - placeholder - check_logging - triage: empty metrics.json - triage: noisy logs changes in k8s-infra-e2e-* projects - expected audit logs are present - check_monitoring - dashboards exist for k8s-infra-prow-build - check_organization: - description is present - roles match definition in infra/gcp/roles Things to consider for followup: - check deletions - check all audit files not just those in git-status - add support for - iam.json changes - custom project iam role changes - service-account/ changes - services/compute/project-infa.json - not bash
Member
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of bash to try and categorize or triage audit pr changes against
policies, triage known policy violations, or special cases. Takes a pass
through any modified or untracked files according to git, and commits any
that are recognized. The goal is to have 0 files left by the end
Things to consider for followup:
I used this to review #2094