Skip to content

groups: Add code-organization group#2085

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
navidshaikh:pr/new-group-for-snyk
May 24, 2021
Merged

groups: Add code-organization group#2085
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
navidshaikh:pr/new-group-for-snyk

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented May 24, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. wg/k8s-infra labels May 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp May 24, 2021 14:28
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
 for managing snyk scan CI job secrets
@navidshaikh navidshaikh force-pushed the pr/new-group-for-snyk branch from 15a758f to a9a3312 Compare May 24, 2021 14:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2021
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented May 24, 2021

I'll open a followup PR to give this group permissions to admin the snyk secret

@k8s-ci-robot k8s-ci-robot merged commit 09fea3d into kubernetes:main May 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 24, 2021
@navidshaikh navidshaikh deleted the pr/new-group-for-snyk branch May 24, 2021 19:34
@BenTheElder
Copy link
Copy Markdown
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants