image-builder/capg: add more permissions to the service account#2061
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Jun 2, 2021
Merged
image-builder/capg: add more permissions to the service account#2061k8s-ci-robot merged 1 commit intokubernetes:mainfrom
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
wg/k8s-infra
cncf-cla: yes
cpanato
force-pushed
the
update-permission
branch
from
c5e483f to
e0ecd80
Compare
cpanato
commented
May 19, 2021
ameukam
reviewed
May 19, 2021
spiffxp
suggested changes
May 19, 2021
k8s-ci-robot
added
the
needs-rebase
cpanato
force-pushed
the
update-permission
branch
from
e0ecd80 to
0ad72c3
Compare
k8s-ci-robot
removed
the
needs-rebase
Member
|
/lgtm Let's try with this set of permissions. |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
Running : |
Member
Author
|
@ameukam let me know when is ready and I will try to trigger the job |
Member
|
Vaccine shot forced me to stay away from computers today. I got: Ensuring GKE clusters in 'k8s-infra-prow-build-trusted' can run pods in 'test-pods' as 'gcb-builder-cluster-api-gcp@k8s-staging-cluster-api-gcp.iam.gserviceaccount.com'
./lib_iam.sh: line 228: local: serviceaccount: readonly variableI'm looking into it. |
ameukam
added a commit
to ameukam/k8s.io
that referenced
this pull request
Jun 2, 2021
Followup of kubernetes#2061. `ensure_staging_gcb_builder_service_account` invokes `ensure_serviceaccount_role_binding` lib_iam.sh function but can't be used with readonly variables. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after we merge: #2057 and #2025
the periodic job ran https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-image-builder-gcp-all-nightly/1394944554532081664 but we got an error
So looks like we need to give a bit more permissions to the svcacc in order to work.
doing a search saw the
role/editorhave the necessary permissions. However, I don't know if this the correct way to enable it./assign @spiffxp @ameukam