Skip to content

Fix group name for II coop.#1972

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ameukam:fix-group-name
Apr 26, 2021
Merged

Fix group name for II coop.#1972
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
ameukam:fix-group-name

Conversation

@ameukam
Copy link
Member

@ameukam ameukam commented Apr 26, 2021

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from BobyMCbobs and hh April 26, 2021 14:43
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2021
@ameukam
Copy link
Member Author

ameukam commented Apr 26, 2021

/assign @spiffxp @dims

@ameukam
Copy link
Member Author

ameukam commented Apr 26, 2021

Tried to applied the binding for this group but got :

Error: Request "Create IAM Members roles/owner group:k8s-infra-ii-coop@kubernetes.io for \"project \\\"projects/k8s-infra-ii-sandbox\\\"\"" returned error: Error applying IAM policy for project "projects/k8s-infra-ii-sandbox": Error setting IAM policy for project "projects/k8s-infra-ii-sandbox": googleapi: Error 400: Request contains an invalid argument., badRequest

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Apr 26, 2021

This issue was the non-existence of k8s-infra-ii-coop@kubernetes.io. @spiffxp made a manual reconciliation.

./terraform apply -auto-approve
data.google_organization.org: Refreshing state... [id=organizations/758905017065]
data.google_billing_account.account: Refreshing state... [id=018801-93540E-22A20E]
google_project.project: Refreshing state... [id=projects/k8s-infra-ii-sandbox]
google_project_service.project["cloudbuild.googleapis.com"]: Refreshing state... [id=k8s-infra-ii-sandbox/cloudbuild.googleapis.com]
google_project_service.project["storage-component.googleapis.com"]: Refreshing state... [id=k8s-infra-ii-sandbox/storage-component.googleapis.com]
google_project_service.project["containerregistry.googleapis.com"]: Refreshing state... [id=k8s-infra-ii-sandbox/containerregistry.googleapis.com]
google_project_service.project["containeranalysis.googleapis.com"]: Refreshing state... [id=k8s-infra-ii-sandbox/containeranalysis.googleapis.com]
google_project_service.project["container.googleapis.com"]: Refreshing state... [id=k8s-infra-ii-sandbox/container.googleapis.com]
google_project_iam_member.k8s_infra_ii_coop: Creating...
google_project_iam_member.k8s_infra_ii_coop: Still creating... [10s elapsed]
google_project_iam_member.k8s_infra_ii_coop: Creation complete after 11s [id=projects/k8s-infra-ii-sandbox/roles/owner/group:k8s-infra-ii-coop@kubernetes.io]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Copy link
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d309e7b into kubernetes:main Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 26, 2021
@spiffxp
Copy link
Contributor

spiffxp commented Apr 26, 2021

Followup to #1967
ref: #1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants