audit: update as of 2021-04-08 #1874
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,12 +20,6 @@ | |
| ], | ||
| "role": "roles/editor" | ||
| }, | ||
|
Comment on lines
-23
to
-28
Contributor
There was a problem hiding this comment. Expected, a result of running Closes out #299 for k8s-artifacts-* projects |
||
| { | ||
| "members": [ | ||
| "group:k8s-infra-artifact-admins@kubernetes.io" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,12 +26,6 @@ | |
| ], | ||
| "role": "roles/editor" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-artifact-admins@kubernetes.io", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,12 +13,6 @@ | |
| ], | ||
| "role": "roles/editor" | ||
| }, | ||
|
Comment on lines
-16
to
-21
Contributor
There was a problem hiding this comment. Expected, a result of running Closes out #299 for k8s-conform |
||
| { | ||
| "members": [ | ||
| "group:k8s-infra-artifact-admins@kubernetes.io" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,12 +20,6 @@ | |
| ], | ||
| "role": "roles/editor" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-artifact-admins@kubernetes.io", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,12 +12,6 @@ | |
| ], | ||
| "role": "roles/editor" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-artifact-admins@kubernetes.io", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
| "bindings": [ | ||
| { | ||
| "members": [ | ||
|
Contributor
There was a problem hiding this comment. Expected, a result of running Closes out #299 for k8s-gsuite project |
||
| "user:wg-k8s-infra-api@kubernetes.io" | ||
| ], | ||
| "role": "roles/owner" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-group-admins@kubernetes.io", | ||
|
Contributor
There was a problem hiding this comment. A result of running I'm surprised this binding wasn't here already, guessing someone didn't run this script after making a change (and it was probably me) |
||
| "serviceAccount:gsuite-groups-manager@k8s-gsuite.iam.gserviceaccount.com" | ||
| ], | ||
| "role": "roles/secretmanager.secretAccessor" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,7 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-prow-oncall@kubernetes.io" | ||
|
Contributor
There was a problem hiding this comment. This change is expected for all k8s-infra-e2e-* projects due to #1859 (comment) This addresses #299 for all k8s-infra-e2e-* projects |
||
| ], | ||
| "role": "roles/owner" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,7 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-prow-oncall@kubernetes.io" | ||
| ], | ||
| "role": "roles/owner" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,7 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-prow-oncall@kubernetes.io" | ||
| ], | ||
| "role": "roles/owner" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,7 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-prow-oncall@kubernetes.io" | ||
| ], | ||
| "role": "roles/owner" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,7 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-prow-oncall@kubernetes.io" | ||
| ], | ||
| "role": "roles/owner" | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Org level role changes are expected. There were a result of running
./infra/gcp/ensure-organization.shafter having refreshed roles, ref: #1859 (comment)