Remove org-level role/binding cleanup, improve lib_iam output#1794
Merged
k8s-ci-robot merged 4 commits intokubernetes:mainfrom Mar 17, 2021
Merged
Remove org-level role/binding cleanup, improve lib_iam output#1794k8s-ci-robot merged 4 commits intokubernetes:mainfrom
k8s-ci-robot merged 4 commits intokubernetes:mainfrom
Conversation
gcloud iam functions have noisy output, trim down to relevent info - no error if role already removed - no "policy updated" is policy didn't need to be updated - diff before/after of policy changes in flat/concise format
they have been removed, cleanup no longer necessary
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/uncc @bartsmykla |
Member
|
/lgtm |
Contributor
Author
|
/hold cancel |
Contributor
Author
|
Contributor
Author
|
The above output is a bit sanitized, the first time I ran the script, it halted after updating Opened #1801 to address |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of umbrella issue to manage organization-level IAM assets (ref: #1659)
Followup to previous PRs:
See individual commit messages for details.
The first two commits are hopefully going to dramatically reduce output from IAM changes, such that unexpected additions or removals are more likely to stand out. A bunch of infra/gcp scripts could be updated to use
lib_iam.shinstead of calling gcloud directly.