Skip to content

hack: clean up verify scripts#1771

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
nikhita:verify-script-follow-ups
Mar 9, 2021
Merged

hack: clean up verify scripts#1771
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
nikhita:verify-script-follow-ups

Conversation

@nikhita
Copy link
Member

@nikhita nikhita commented Mar 9, 2021

Addresses comments in #1765

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra labels Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2021
@nikhita
Copy link
Member Author

nikhita commented Mar 9, 2021

/assign @ameukam

@nikhita
Copy link
Member Author

nikhita commented Mar 9, 2021

cc @spiffxp

@ameukam
Copy link
Member

ameukam commented Mar 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit c3b4923 into kubernetes:main Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@nikhita nikhita deleted the verify-script-follow-ups branch March 9, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants