Don't audit the node count in a cluster#1744
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Mar 2, 2021
Merged
Conversation
Those things change over time, not worth alerting on.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Member
Author
|
I could be convinced we DO want to audit this, in which case go ahead and close it. |
Closed
spiffxp
approved these changes
Mar 2, 2021
Contributor
spiffxp
left a comment
spiffxp
left a comment
There was a problem hiding this comment.
/approve
/lgtm
fine by me
if we want to really audit these more fully, we should dump --format=yaml and strip out things we know will change automatically
but that can be a later task when we find the bandwidth or need
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those things change over time, not worth alerting on.