Skip to content

slack-infra: grant access to mrbobbytables, jeefy and nikhita#1719

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
nikhita:slack-admins-access
Feb 24, 2021
Merged

slack-infra: grant access to mrbobbytables, jeefy and nikhita#1719
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
nikhita:slack-admins-access

Conversation

@nikhita
Copy link
Member

@nikhita nikhita commented Feb 24, 2021

Ref:

Since slack admins can provision tokens, this PR grants @mrbobbytables and @jeefy (slack admins) access to slack-infra resources.

  • @mrbobbytables is a sig-contribex lead
  • @jeefy is a root approver for slack-infra
  • @nikhita as contribex TL (Edit: also adding myself as contribex TL)

/assign @mrbobbytables @jeefy
can you confirm if this okay for you?

/hold
for @mrbobbytables and @jeefy to ack

/assign @spiffxp
for approval

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp February 24, 2021 10:14
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. wg/k8s-infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2021
@nikhita
Copy link
Member Author

nikhita commented Feb 24, 2021

@mrbobbytables @jeefy apologies for voluntolding, please delegate as needed :P

@ameukam
Copy link
Member

ameukam commented Feb 24, 2021

/lgtm

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2021
@jeefy
Copy link
Member

jeefy commented Feb 24, 2021

ACK, Fine by me!

@nikhita nikhita force-pushed the slack-admins-access branch from 6d5a6dc to a81db7f Compare February 24, 2021 15:57
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 24, 2021
Since slack admins can provision tokens, this commit grants Bob and
Jeff (slack admins) access to slack-infra resources.

Also adding myself as contribex TL after speaking to mrbobbytables
and spiffxp.

- Bob and Jeff are slack admins - https://github.com/kubernetes/community/blob/master/communication/moderators.md#moderators
- Bob is a sig-contribex chair
- Jeff is a slack-infra root approver
- Nikhita is a contribex TL
@nikhita nikhita force-pushed the slack-admins-access branch from a81db7f to 2ec04ac Compare February 24, 2021 15:58
@nikhita nikhita changed the title slack-infra: grant access to mrbobbytables and jeefy slack-infra: grant access to mrbobbytables, jeefy and nikhita Feb 24, 2021
Copy link
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold cancel
I got confirmation from @mrbobbytables out of band

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member Author

nikhita commented Feb 24, 2021

Adding myself as contribex TL to help with pushing things along

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6ca1d09 into kubernetes:main Feb 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 24, 2021
@nikhita nikhita deleted the slack-admins-access branch February 24, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants