partial-audit: k8s-staging-* update as of 2021-02-24#1712
partial-audit: k8s-staging-* update as of 2021-02-24#1712k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @cncf-ci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
spiffxp
left a comment
There was a problem hiding this comment.
/approve
/lgtm
A few things to fix in followup, but this generally looks good.
I'll see what I can do about the CLA while we wait for cncf-ci-robot to get it signed
| NAME TITLE | ||
| cloudbuild.googleapis.com Cloud Build API | ||
| cloudkms.googleapis.com Cloud Key Management Service (KMS) API | ||
| compute.googleapis.com Compute Engine API |
There was a problem hiding this comment.
more APIs getting enabled that shouldn't be, I'm guessing this is one of the org admins migrating around on console...
| "projectEditor:k8s-staging-e2e-test-images", | ||
| "projectOwner:k8s-staging-e2e-test-images" | ||
| "projectOwner:k8s-staging-e2e-test-images", | ||
| "serviceAccount:456067983721@cloudbuild.gserviceaccount.com" |
There was a problem hiding this comment.
I don't think this belongs here, but I'll allow it for now.
Would like to revisit GCR and GCB permissions in general based on the auditing I was doing while troubleshooting in kubernetes/test-infra#20884 (comment)
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| policytroubleshooter.googleapis.com Policy Troubleshooter API |
There was a problem hiding this comment.
this was definitely me clicking around in gcp console while doing kubernetes/test-infra#20884 (comment)
nit for followup: can we consider dumping this in a format that doesn't change whitespace when services change?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cncf-ci, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override cla/linuxfoundation |
|
/check-cla |
Audit Updates wg-k8s-infra